Rework wifi error #4467
Merged
Rework wifi error #4467
+151
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
approved these changes
Nov 10, 2025
esp-radio/src/wifi/mod.rs
Outdated
| ), | ||
| WifiError::OutOfMemory => write!(f, "Out of memory."), | ||
| WifiError::NotStarted => write!(f, "Wi-Fi driver was not started."), | ||
| WifiError::NotStopped => write!(f, " Wi-Fi driver was not stopped."), |
Contributor
There was a problem hiding this comment.
Suggested change
| WifiError::NotStopped => write!(f, " Wi-Fi driver was not stopped."), | |
| WifiError::NotStopped => write!(f, "Wi-Fi driver was not stopped."), |
esp-radio/src/wifi/mod.rs
Outdated
| WifiError::WakeFailed => { | ||
| write!(f, "Wi-Fi is in sleep state (RF closed) and wakeup failed.") | ||
| } | ||
| WifiError::WouldBlock => write!(f, " The caller would block."), |
Contributor
There was a problem hiding this comment.
Suggested change
| WifiError::WouldBlock => write!(f, " The caller would block."), | |
| WifiError::WouldBlock => write!(f, "The caller would block."), |
bugadani
reviewed
Nov 10, 2025
esp-radio/src/wifi/mod.rs
Outdated
| /// Wi-Fi is in sleep state (RF closed) and wakeup failed | ||
| WakeFailed, | ||
|
|
||
| /// The caller would block |
Contributor
There was a problem hiding this comment.
It's not the caller would block, but the call/operation itself, isn't it?
Contributor
Author
There was a problem hiding this comment.
I honestly just copied the description from ESP-IDF but yes - this sounds a bit off 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Closes #4453
Closes #4454
Not sure about the migration-guide - I wouldn't expect anyone to really handle specific errors (especially given the errors were designed in an unfortunate way)
Testing
CI